From: umherirrender <umherirrender_de.wp@web.de>
Date: Fri, 26 Sep 2014 17:31:51 +0000 (+0200)
Subject: Remove LinkSearchPage::doQuery override
X-Git-Tag: 1.31.0-rc.0~13285
X-Git-Url: http://git.cyclocoop.org/%7D%7Cconcat%7B?a=commitdiff_plain;h=f5b214d5f9fffc9b25787ca434be11c299c843db;p=lhc%2Fweb%2Fwiklou.git

Remove LinkSearchPage::doQuery override

It is not called and not working, because it missed return statements.

The validation check is done in getQueryInfo and the message is added in
execute, when needed.

Change-Id: I9acbd2f09a922d5a7d66e8ce55e8d24ae65ab560
---

diff --git a/includes/specials/SpecialLinkSearch.php b/includes/specials/SpecialLinkSearch.php
index 2d6213ae40..05c89c2003 100644
--- a/includes/specials/SpecialLinkSearch.php
+++ b/includes/specials/SpecialLinkSearch.php
@@ -285,24 +285,6 @@ class LinkSearchPage extends QueryPage {
 		return $this->msg( 'linksearch-line' )->rawParams( $urlLink, $pageLink )->escaped();
 	}
 
-	/**
-	 * Override to check query validity.
-	 *
-	 * @param mixed $offset Numerical offset or false for no offset
-	 * @param mixed $limit Numerical limit or false for no limit
-	 */
-	function doQuery( $offset = false, $limit = false ) {
-		list( $this->mMungedQuery, ) = LinkSearchPage::mungeQuery( $this->mQuery, $this->mProt );
-		if ( $this->mMungedQuery === false ) {
-			$this->getOutput()->addWikiMsg( 'linksearch-error' );
-		} else {
-			// For debugging
-			// Generates invalid xhtml with patterns that contain --
-			//$this->getOutput()->addHTML( "\n<!-- " . htmlspecialchars( $this->mMungedQuery ) . " -->\n" );
-			parent::doQuery( $offset, $limit );
-		}
-	}
-
 	/**
 	 * Override to squash the ORDER BY.
 	 * We do a truncated index search, so the optimizer won't trust